-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testutil/validatormock: implement #187
Conversation
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage ? 52.61%
=======================================
Files ? 43
Lines ? 2693
Branches ? 0
=======================================
Hits ? 1417
Misses ? 1123
Partials ? 153 Continue to review full report at Codecov.
|
aggBits := bitfield.NewBitlist(duty.CommitteeLength) | ||
aggBits.SetBitAt(duty.ValidatorCommitteeIndex, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dB2510 here you can see that validator client includes duty.CommitteeLength
and duty.ValidatorCommitteeIndex
in the signed attestation. That is what we extract in the validatorapi to identify the DV the ParSignedData belongs to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah got it! now dots are connecting :')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
eth2client.AttestationDataProvider | ||
eth2client.AttesterDutiesProvider | ||
eth2client.AttestationsSubmitter | ||
eth2client.SlotsPerEpochProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetical order maybe here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
// Signature stub function | ||
signFunc := func(ctx context.Context, key eth2p0.BLSPubKey, _ eth2p0.SigningData) (eth2p0.BLSSignature, error) { | ||
var sig eth2p0.BLSSignature | ||
copy(sig[:], key[:]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do actual signature using kryptology?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This make it easy to see which pubkey signed in the testdata.
To test signature aggregation, we need to create signatures. This add a validator client mock that performs attestations, including signatures as per spec. This will be used to test the SigAgg component.
category: testing
ticket: #184